-
-
Notifications
You must be signed in to change notification settings - Fork 518
Convert in-depth topics to use gjs #2127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for ember-guides ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Some of the built-in imports are documented here: https://guides.emberjs.com/release/components/template-tag-format/#toc_importing-built-ins |
But not 'component' or 'helper' or 'modifier'. |
ya, these are built-in keywords |
Oh, nice. I can just delete those TODO placeholders. |
…elpers as keywords
|
Would be great to also have those documented as built-in keyword on the template tag page! |
- no extensions - no relative paths
This PR updates the 4 markdown files in the Core Concepts / In-Depth Topics to use gjs.
I tried to limit the changes here to only migrating from
js+hbstogjs. In a few places, some reordering of the prose around the code snippets was unavoidable. Based on the number of changes, I'd recommend going through the rendered docs and see if anything looks awry.Some notes:
gjsrequires explicit imports, I added imports for things likeInputandmodifier. But I don't know the imports for thecomponenthelper andhelperhelper, so those should be addressed.autotracking-in-depth, some of the snippets now have diff indicators where they didn't before.rendering-values, everything that was justhandlebarshas been wrapped in<template></template>in agjsblock. Many of these care incomplete however, because they reference stuff that is not in scope. I think this is fine, but maybe somebody else has an opinion on a better way to handle these.Leaving as a draft until I figure out the imports.